small improvements

This commit is contained in:
bronku 2026-06-11 09:10:27 +02:00
parent bb32802324
commit 5f2d6f00bc
10 changed files with 117 additions and 178 deletions

View file

@ -3,46 +3,52 @@ package store
import (
"database/sql"
"errors"
"fmt"
"log"
"time"
"git.bronku.xyz/bronku/cake-order-tracker/config"
"git.bronku.xyz/bronku/cake-order-tracker/models"
)
// #todo update labels in templates
func (s *Store) parseOrderRow(row *sql.Rows) (models.Order, error) {
func (s *Store) scanOrderRow(row *sql.Rows) (models.Order, error) {
var out models.Order
var orderDate, deliveryDate string
err := row.Scan(&out.ID, &out.Name, &out.Surname, &out.Phone, &out.Location, &orderDate, &deliveryDate, &out.Status, &out.Paid)
if err != nil {
return out, err
}
out.Accepted, _ = time.Parse("2006-01-02 15:04", orderDate)
out.Date, _ = time.Parse("2006-01-02 15:04", deliveryDate)
out.Cakes = make([]models.Cake, 0)
rows, err := s.db.Query("select cake, amount from ordered_cake where customer_order = ?;", out.ID)
out.Accepted, err = time.Parse(config.DateTimeFormat, orderDate)
if err != nil {
return out, err
}
out.Date, err = time.Parse(config.DateTimeFormat, deliveryDate)
if err != nil {
return out, err
}
return out, nil
}
func (s *Store) loadOrderCakes(orderID int) ([]models.Cake, error) {
var cakes []models.Cake
rows, err := s.db.Query("select cake, amount from ordered_cake where customer_order = ?;", orderID)
if err != nil {
return cakes, err
}
defer rows.Close()
for rows.Next() {
var newCake models.Cake
err = rows.Scan(&newCake.ID, &newCake.Amount)
if err != nil {
return out, err
var c models.Cake
if err := rows.Scan(&c.ID, &c.Amount); err != nil {
return cakes, err
}
cakeData, err := s.GetCake(newCake.ID)
cakeData, err := s.GetCake(c.ID)
if err != nil {
continue
}
newCake.Name = cakeData.Name
newCake.Price = cakeData.Price
out.Cakes = append(out.Cakes, newCake)
c.Name = cakeData.Name
c.Price = cakeData.Price
cakes = append(cakes, c)
}
return out, nil
return cakes, rows.Err()
}
func (s *Store) getOrdersFromQuery(query string, args ...any) ([]models.Order, error) {
@ -54,9 +60,12 @@ func (s *Store) getOrdersFromQuery(query string, args ...any) ([]models.Order, e
defer rows.Close()
for rows.Next() {
order, err := s.parseOrderRow(rows)
order, err := s.scanOrderRow(rows)
if err != nil {
continue
}
order.Cakes, err = s.loadOrderCakes(order.ID)
if err != nil {
fmt.Println(err)
continue
}
out = append(out, order)
@ -78,8 +87,8 @@ func (s *Store) GetOrder(id int) (models.Order, error) {
}
func (s *Store) GetOrders(from, to time.Time) ([]models.Order, error) {
start := from.Format("2006-01-02") + " 00:00"
end := to.Format("2006-01-02") + " 99:99"
start := from.Format(config.DateFormat) + " 00:00"
end := to.Format(config.DateFormat) + " 99:99"
if to.IsZero() {
end = "9999-99-99 99:99"
}
@ -88,15 +97,15 @@ func (s *Store) GetOrders(from, to time.Time) ([]models.Order, error) {
}
func (s *Store) UpdateOrderContents(tx *sql.Tx, newOrder models.Order) error {
query := "delete from ordered_cake where customer_order = ?;"
_, err := tx.Exec(query, newOrder.ID)
q := "delete from ordered_cake where customer_order = ?;"
_, err := tx.Exec(q, newOrder.ID)
if err != nil {
return err
}
query = "insert into ordered_cake(customer_order, cake, amount) values (?,?,?);"
q = "insert into ordered_cake(customer_order, cake, amount) values (?,?,?);"
for _, e := range newOrder.Cakes {
_, err := tx.Exec(query, newOrder.ID, e.ID, e.Amount)
_, err := tx.Exec(q, newOrder.ID, e.ID, e.Amount)
if err != nil {
return err
}
@ -109,17 +118,17 @@ func (s *Store) UpdateOrder(newOrder models.Order) error {
if err != nil {
return err
}
query := "update customer_order set name = ?, surname = ?, phone = ?, location = ?, order_date = ?, delivery_date = ?, status = ?, paid = ? where id = ?;"
q := "update customer_order set name = ?, surname = ?, phone = ?, location = ?, order_date = ?, delivery_date = ?, status = ?, paid = ? where id = ?;"
accepted := newOrder.Accepted.Format("2006-01-02 15:04")
date := newOrder.Date.Format("2006-01-02 15:04")
accepted := newOrder.Accepted.Format(config.DateTimeFormat)
date := newOrder.Date.Format(config.DateTimeFormat)
tx, err := s.db.Begin()
if err != nil {
return err
}
_, err = tx.Exec(query, newOrder.Name, newOrder.Surname, newOrder.Phone, newOrder.Location, accepted, date, newOrder.Status, newOrder.Paid, newOrder.ID)
_, err = tx.Exec(q, newOrder.Name, newOrder.Surname, newOrder.Phone, newOrder.Location, accepted, date, newOrder.Status, newOrder.Paid, newOrder.ID)
if err != nil {
_ = tx.Rollback()
return err
@ -132,6 +141,7 @@ func (s *Store) UpdateOrder(newOrder models.Order) error {
}
err = tx.Commit()
log.Printf("UPDATE order id=%d name=%q status=%q", newOrder.ID, newOrder.Name, newOrder.Status)
return nil
}
@ -139,16 +149,16 @@ func (s *Store) SaveOrder(newOrder models.Order) (int, error) {
if newOrder.ID != 0 {
return newOrder.ID, s.UpdateOrder(newOrder)
}
query := "insert into customer_order(name, surname, phone, location, order_date, delivery_date, status, paid) values (?, ?, ?, ?, ?, ?, ?, ?);"
q := "insert into customer_order(name, surname, phone, location, order_date, delivery_date, status, paid) values (?, ?, ?, ?, ?, ?, ?, ?);"
tx, err := s.db.Begin()
if err != nil {
return 0, err
}
accepted := newOrder.Accepted.Format("2006-01-02 15:04")
date := newOrder.Date.Format("2006-01-02 15:04")
result, err := tx.Exec(query, newOrder.Name, newOrder.Surname, newOrder.Phone, newOrder.Location, accepted, date, newOrder.Status, newOrder.Paid)
accepted := newOrder.Accepted.Format(config.DateTimeFormat)
date := newOrder.Date.Format(config.DateTimeFormat)
result, err := tx.Exec(q, newOrder.Name, newOrder.Surname, newOrder.Phone, newOrder.Location, accepted, date, newOrder.Status, newOrder.Paid)
if err != nil {
_ = tx.Rollback()
return 0, err
@ -157,16 +167,17 @@ func (s *Store) SaveOrder(newOrder models.Order) (int, error) {
id, err := result.LastInsertId()
if err != nil {
_ = tx.Rollback()
return newOrder.ID, err
return 0, err
}
newOrder.ID = int(id)
err = s.UpdateOrderContents(tx, newOrder)
if err != nil {
_ = tx.Rollback()
return newOrder.ID, err
return 0, err
}
err = tx.Commit()
log.Printf("INSERT order id=%d name=%q status=%q", newOrder.ID, newOrder.Name, newOrder.Status)
return newOrder.ID, err
}